Update Razor to include more C# actions. #3445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds support for find all references, go to definition, go to implementation and CodeLens. - Fixed several bugs which resulted in the Razor language server crashing. - Updated change log to give a brief description of what was added on Razor's side. - Updated test-plan to include quick tests of newly added features
NTaylorMullen
commented
Dec 7, 2019
| @@ -11,6 +11,13 @@ | |||
|
|
|||
| ## 1.21.9 (Not yet released) | |||
| * Use the base filename instead of 'ClassName' in ctor snippet (PR:[#3385](https://github.com/OmniSharp/omnisharp-vscode/pull/3385)) | |||
| * Updated Razor | |||
There was a problem hiding this comment.
@danroth27 I took the approach of a simple changelog. Thoughts?
|
@NTaylorMullen I've rerun the failed CI a couple times to see if it was just being flaky. The failing test has a 15 second time out. Not sure if remapping is pushing this over or not. |
Codecov Report
@@ Coverage Diff @@
## master #3445 +/- ##
======================================
Coverage 89.8% 89.8%
======================================
Files 59 59
Lines 1589 1589
Branches 89 89
======================================
Hits 1427 1427
Misses 151 151
Partials 11 11
Continue to review full report at Codecov.
|
JoeRobich
approved these changes
Dec 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for find all references, go to definition, go to implementation and CodeLens.
Fixed several bugs which resulted in the Razor language server crashing.
Updated change log to give a brief description of what was added on Razor's side.
Updated test-plan to include quick tests of newly added features
Working on getting some Razor grammar goods in the box. We'll see if I can get them into a good enough state; if so i'll update the PR.
@ryanbrandenburg @ajaybhargavb Please look over the changelog / test-plan to ensure I didn't miss anything or if I can word something better.