Add updated Razor grammar for better colorization. #3448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NTaylorMullen
commented
Dec 9, 2019
NTaylorMullen
commented
- This is an initial release of Razor's improved grammar. It doesn't support everything but it's superior to what's currently in the box.
- As part of this grammar we added support for Razor comments. Because of this I've updated the langauge-configuration.json as well to reflect changes from @ajaybhargavb.
- Things that don't currently work: Update TextMate grammar to properly represent Razor content. aspnetcore#14287 (comment)
- This is an initial release of Razor's improved grammar. It doesn't support everything but it's superior to what's currently in the box. - As part of this grammar we added support for Razor comments. Because of this I've updated the langauge-configuration.json as well to reflect [changes](dotnet/razor@24c0973) from @ajaybhargavb. - Things that don't currently work: dotnet/aspnetcore#14287 (comment)
JoeRobich
approved these changes
Dec 9, 2019
Codecov Report
@@ Coverage Diff @@
## master #3448 +/- ##
======================================
Coverage 89.8% 89.8%
======================================
Files 59 59
Lines 1589 1589
Branches 89 89
======================================
Hits 1427 1427
Misses 151 151
Partials 11 11
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.