Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore virtual files #3592

Merged
merged 2 commits into from
Feb 25, 2020
Merged

Conversation

ryanbrandenburg
Copy link
Contributor

Fixes dotnet/aspnetcore#18927.

This seemed to require editing a lot of test files to exclude the Blazor project from running other tests, if anyone on the O# side has a better way to handle that I'm open.

CC @NTaylorMullen, @ajaybhargavb

@ryanbrandenburg
Copy link
Contributor Author

ryanbrandenburg commented Feb 20, 2020

@JoeRobich / @filipw I'm not 100% sure this is the correct fix, maybe you could correct my thinking (or convince me I'm already right).

Repro steps:

  1. dotnet new blazorserver
  2. In Index.razor add the line @DoesNotExist.
  3. Watch the Problems pane, you should see an entry for Index.razor_virtual.cs flash briefly (occasionally it stays permanently). If you didn't see it try again, it should repro each time.

When I track this down I can find requests to _validateDocument for the Index.cshtml_virtual.cs file, which has returned a result for Index.cshtml, even though the request was for _virtual.cs.

Hopefully that all makes sense, I can go into more detail offline if you need more context or a demo.

@JoeRobich
Copy link
Member

@ryanbrandenburg I tried the step you listed and this is what I see in the latest release 1.21.12. I do see a reported problem, but it is for Index.razor.

image

@JoeRobich
Copy link
Member

JoeRobich commented Feb 20, 2020

@ryanbrandenburg I spoke too soon. I see what you are talking about.
image

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #3592 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3592   +/-   ##
======================================
  Coverage    89.8%   89.8%           
======================================
  Files          59      59           
  Lines        1589    1589           
  Branches       89      89           
======================================
  Hits         1427    1427           
  Misses        151     151           
  Partials       11      11
Flag Coverage Δ
#integration ?
#unit 89.8% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ebb473...e78397c. Read the comment docs.

@ryanbrandenburg
Copy link
Contributor Author

@JoeRobich, I've updated it with your feedback but it seems I don't have permissions to merge.

@JoeRobich JoeRobich merged commit ce7433c into dotnet:master Feb 25, 2020
@JoeRobich
Copy link
Member

Thanks @ryanbrandenburg !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Occasional mixing of code-behind and razor file when renaming razor file
2 participants