-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore virtual files #3592
Ignore virtual files #3592
Conversation
@JoeRobich / @filipw I'm not 100% sure this is the correct fix, maybe you could correct my thinking (or convince me I'm already right). Repro steps:
When I track this down I can find requests to _validateDocument for the Hopefully that all makes sense, I can go into more detail offline if you need more context or a demo. |
@ryanbrandenburg I tried the step you listed and this is what I see in the latest release 1.21.12. I do see a reported problem, but it is for Index.razor. |
@ryanbrandenburg I spoke too soon. I see what you are talking about. |
c35ca2e
to
e6baffa
Compare
Codecov Report
@@ Coverage Diff @@
## master #3592 +/- ##
======================================
Coverage 89.8% 89.8%
======================================
Files 59 59
Lines 1589 1589
Branches 89 89
======================================
Hits 1427 1427
Misses 151 151
Partials 11 11
Continue to review full report at Codecov.
|
e6baffa
to
8cb1662
Compare
@JoeRobich, I've updated it with your feedback but it seems I don't have permissions to merge. |
Thanks @ryanbrandenburg ! |
Fixes dotnet/aspnetcore#18927.
This seemed to require editing a lot of test files to exclude the Blazor project from running other tests, if anyone on the O# side has a better way to handle that I'm open.
CC @NTaylorMullen, @ajaybhargavb