-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Razor version #3594
Update Razor version #3594
Conversation
4ce9cef
to
6935514
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great set of improvements!
Codecov Report
@@ Coverage Diff @@
## master #3594 +/- ##
======================================
Coverage 89.8% 89.8%
======================================
Files 59 59
Lines 1589 1589
Branches 89 89
======================================
Hits 1427 1427
Misses 151 151
Partials 11 11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the \u stuff gets reverted
@@ -498,17 +498,17 @@ | |||
"items": { | |||
"type": "string" | |||
}, | |||
"description": "Array of symbol server URLs (example: http\u200b://MyExampleSymbolServer) or directories (example: /build/symbols) to search for .pdb files. These directories will be searched in addition to the default locations -- next to the module and the path where the pdb was originally dropped to.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I recall they had these in there for a reason, you should probably add them back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh interesting, I'm curious to know what the reasoning behind this is. @JoeRobich why were these needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why were these needed?
I have no idea if they are needed. Our update package dependencies launch task will restore them prior to the next release. So no reason to do it here.
"default": [] | ||
}, | ||
"searchMicrosoftSymbolServer": { | ||
"type": "boolean", | ||
"description": "If 'true' the Microsoft Symbol server (https\u200b://msdl.microsoft.com\u200b/download/symbols) is added to the symbols search path. If unspecified, this option defaults to 'false'.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above for all \u200b
.
cc @NTaylorMullen @ryanbrandenburg @JoeRobich