-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use workspace.findFiles instead of glob #3681
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3681 +/- ##
==========================================
+ Coverage 89.8% 89.91% +0.11%
==========================================
Files 59 59
Lines 1589 1597 +8
Branches 89 89
==========================================
+ Hits 1427 1436 +9
+ Misses 151 150 -1
Partials 11 11
Continue to review full report at Codecov.
|
src/omnisharp/options.ts
Outdated
return excludePaths; | ||
} | ||
|
||
let excludeFilesOption = workspaceConfig.get<{ [i: string]: boolean }>('files.exclude'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity does VSCode pre-fill node_modules in this list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately it wasn't set for the dotnet new razor
project I created to test with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might make sense for us to auto-include node_modules
and whatever Unity's package folder is if it doesn't already exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should also include search.exclude
.. hmm..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good news is that Unity seems to create a .vscode/settings.json which has an extensive files.exclude
defined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to include search.exclude
paths which by default include node_modules
. Unity's settings.json includes the Library/PackageCache in its files.exclude
so I think we are covered from these scenarios.
isBlazorWebAssemblyProject
usedglob
to search for launchSettings.json files. It was being invoked 3 different times for each project within the workspace byrequestWorkspaceInformation
.Based on this advice:
Updated
isBlazorWebAssemblyProject
to usevscode.workspace.findFiles
and also use the excluded paths defined infiles.exclude
Potential fix for #3673