Add Visual Studio 2019 themes with semantic colors #3790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryanbrandenburg would it make sense to include Razor's semantic goodness here? |
|
My current understanding is that we will not need to make edits to themes to support Razor Semantic Colorization, we should be able to just use the default scopes. |
|
@ryanbrandenburg @NTaylorMullen What we found was that colors were not defined for the scopes we were using which caused VS Code to fall back to the textmate grammar scopes. So to better show off the semantic colors we wanted to include themes that really made it apparent. |
RikkiGibson
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding color themes that show off the semantic highlighting and closely match Visual Studio 2019 editor colors.