Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remoteProcessPickerScript windows ssh exit #4225

Merged
merged 3 commits into from
Dec 7, 2020
Merged

Update remoteProcessPickerScript windows ssh exit #4225

merged 3 commits into from
Dec 7, 2020

Conversation

alanmbarr
Copy link
Contributor

On windows vscode using the openssh client the command does not exit by default which does not allow vscode to prompt available processes to the user. This continues to work on linux despite redundant exit command.

On windows vscode using the openssh client the command does not exit by default which does not allow vscode to prompt available processes to the user. This continues to work on linux despite redundant exit command.
@codecov
Copy link

codecov bot commented Nov 21, 2020

Codecov Report

Merging #4225 (862bef8) into master (2489158) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4225   +/-   ##
=======================================
  Coverage   85.99%   85.99%           
=======================================
  Files          60       60           
  Lines        1857     1857           
  Branches      215      215           
=======================================
  Hits         1597     1597           
  Misses        200      200           
  Partials       60       60           
Flag Coverage Δ
integration 100.00% <ø> (ø)
unit 85.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a1532...c9ba020. Read the comment docs.

@alanmbarr
Copy link
Contributor Author

This pull request is related to this open issue for using the remote picker process in windows using the windows openssh client #3482

@JoeRobich JoeRobich merged commit 470cef6 into dotnet:master Dec 7, 2020
@alanmbarr alanmbarr deleted the remoteprocessscript-patch-1 branch December 17, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants