Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Razor to support 6.0.0-alpha.1.20575.5. #4278

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

NTaylorMullen
Copy link
Contributor

  • Mostly bug fixes & minor refactorings in regards to VSCode's operations.

/cc @ajaybhargavb @ryanbrandenburg @TanayParikh

- Mostly bug fixes & minor refactorings in regards to VSCode's operations.
Copy link
Contributor

@TanayParikh TanayParikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we'll have to copy over these changes manually.

@NTaylorMullen
Copy link
Contributor Author

I believe we'll have to copy over these changes manually.

That's for preview3

Copy link
Contributor

@TanayParikh TanayParikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh okay, thanks for the clarification!

LGTM then!

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #4278 (e41fe00) into master (a0a0a9d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4278   +/-   ##
=======================================
  Coverage   85.99%   85.99%           
=======================================
  Files          60       60           
  Lines        1857     1857           
  Branches      215      215           
=======================================
  Hits         1597     1597           
  Misses        200      200           
  Partials       60       60           
Flag Coverage Δ
integration 100.00% <ø> (ø)
unit 85.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0a0a9d...e41fe00. Read the comment docs.

@NTaylorMullen NTaylorMullen merged commit 4b1c180 into master Dec 8, 2020
@NTaylorMullen NTaylorMullen deleted the nimullen/razor.6.0.0-alpha.1.20575.5 branch December 8, 2020 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants