Fixes to asset generation #4402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses two issues created by dotnet#4241. 1. Comments were left in when the launch.json content was returned through the configuration provider. 2. The search pattern for launching the browser was double-escaped This also makes some tweaks to our .gitignore to ignore some of the files that can be generated in this repo.
gregg-miskelly
force-pushed
the
dev/greggm/assetGenFixes
branch
from
106d00b
to
da2b47d
Compare
NTaylorMullen
approved these changes
Feb 17, 2021
nohwnd
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses two issues created by #4241.
This also makes some tweaks to our .gitignore to ignore some of the files that can be generated in this repo.