-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Regex syntax highlighting #4902
Conversation
Could you add some screenshots to demonstrate what this looks like? |
@TechnologicalPizza Thanks so much for adding these tokens. I think we are missing two things to make this complete.
If you feel up to working on these two tasks, please let me know. Otherwise, I am happy to take this PR as is. |
Seems like something interesting I could look at 👀 |
Some are already defined in the themes. Others will have to be a best guess unless you find something definitive. |
With commit cba7893 these are the default colors that were already in |
@TechnologicalPizza Sorry I haven't followed up. Were there any required changes to the Light theme? |
@JoeRobich I don't think so? The images I uploaded were made with stock themes. This PR doesn't change any themes either. |
Thanks @TechnologicalPizza ! |
Improves semantic highlighting of regex by utilizing Roslyn data that was previously unused.
This "breaks" themes that only style the
regexp
token because new specialized token types were added.