Remove obsolete settings checks for Blazor debugging #4964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The necessary JavaScript debugger configurations are now the default, and cannot be disabled.
winstliu
changed the title
JoeRobich
approved these changes
Dec 19, 2021
|
@50Wliu Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension currently displays false positive prompts that "Additional setup is required to debug Blazor WebAssembly applications" because it's looking for configuration settings that no longer exist. Remove them all, and in the process, streamline the check to only look for the existence of the companion extension.
Details
The extension currently determines if a Blazor workspace is ready for Blazor debugging if:
debug.javascript.usePreviewsetting is true, ORdebug.node.useV3ANDdebug.chrome.useV3settings are true.However,
debug.javascript.usePreviewwas removed in VS Code 1.60 along with the old debugger: https://code.visualstudio.com/updates/v1_60#_javascript-debuggingdebug.node.useV3setting was removed 15 months ago.debug.chrome.useV3was removed in August, and the extension is similarly deprecated in favor of the new built-in debugger.The extension currently sets a minimum VS Code requirement of 1.61.0, meaning that those settings are guaranteed to not control anything. Thus, by removing those checks, we can see that the only remaining check is for the Blazor companion extension, and the code can be greatly simplified to only look for that.
Oh yeah, and the corresponding documentation has already been updated to remove the parts that talk about enabling the debugger preview, so anyone who clicks on the "Learn more" prompt isn't going to get the information they need anyway.