Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter packages to install by framework before attempting install #5041

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

JoeRobich
Copy link
Member

fixes #5032

@JoeRobich
Copy link
Member Author

@nohwnd please take a look

@hichemfantar
Copy link

Any idea which commit caused this behavior to start in the first place ?

@JoeRobich
Copy link
Member Author

Any idea which commit caused this behavior to start in the first place ?

Ah so we are playing the git blame game now? =) It was my commit that moved us to the new O# (#4961).

The changes were to ensure when we built packages we only included the Full Framework O#. I, of course, put my filter in the wrong place and it wasn't noticed during validation. Likely because we were all so excited to get the .NET SDK build of O# in that we had both installed and so the message wasn't being logged.

@hichemfantar
Copy link

Any idea which commit caused this behavior to start in the first place ?

Ah so we are playing the git blame game now? =) It was my commit that moved us to the new O# (#4961).

The changes were to ensure when we built packages we only included the Full Framework O#. I, of course, put my filter in the wrong place and it wasn't noticed during validation. Likely because we were all so excited to get the .NET SDK build of O# in that we had both installed and so the message wasn't being logged.

I was simply curious 😆 Glad you solved it tho. This has been driving many people nuts. Appreciate the fix 🙌

@JoeRobich JoeRobich mentioned this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable terminal output each time a c# project is opened
3 participants