Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear nullability warnings in src #5236

Merged
merged 19 commits into from
May 31, 2022
Merged

Clear nullability warnings in src #5236

merged 19 commits into from
May 31, 2022

Conversation

winstliu
Copy link
Contributor

I'll do my best to call out suspicious changes here:

  • Extension activation now throws if on an unsupported platform
  • ID_LIKE removed from LinuxDistribution FromReleaseInfo

I think that's actually it? The rest of the changes look more-or-less straightforward.

JoeRobich
JoeRobich approved these changes May 28, 2022
View reviewed changes
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @50Wliu! It is great to see the progress you are making.

src/platform.ts Outdated Show resolved Hide resolved
@JoeRobich JoeRobich merged commit 5333a1d into dotnet:master May 31, 2022
@winstliu winstliu deleted the users/winstonliu/src-nullability branch June 1, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winstliu @JoeRobich