Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observer nullability fixes #5349

Merged

Conversation

winstliu
Copy link
Contributor

@winstliu winstliu commented Aug 19, 2022

Changes are pretty straightforward. No behavioral changes (except possibly returning the empty string instead of undefined for SolutionId in telemetry).

Brings the number of strict errors down from 403 to 378.

Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoeRobich JoeRobich merged commit 322d0ff into dotnet:master Aug 19, 2022
@winstliu winstliu deleted the users/winstonliu/observers-nullability branch August 19, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants