Add prerequisite check for running OmniSharp. #5397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
commented
Oct 8, 2022
| @@ -20,8 +20,8 @@ export async function getDotnetInfo(dotNetCliPaths: string[]): Promise<DotnetInf | |||
| return _dotnetInfo; | |||
| } | |||
|
|
|||
| let dotnetExeName = CoreClrDebugUtil.getPlatformExeExtension(); | |||
| let dotnetExecutablePath = undefined; | |||
| let dotnetExeName = join('dotnet', CoreClrDebugUtil.getPlatformExeExtension()); | |||
There was a problem hiding this comment.
This is currently broken in main.
| @@ -231,7 +231,8 @@ | |||
| "darwin" | |||
| ], | |||
| "architectures": [ | |||
| "x86_64" | |||
| "x86_64", | |||
| "arm64" | |||
There was a problem hiding this comment.
Allow x64 Mono build of O# to install on Apple Silicon.
333fred
reviewed
Oct 10, 2022
333fred
approved these changes
Oct 10, 2022
Co-authored-by: Fred Silberberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add actionable prompts when .NET SDK or Mono is missing but required for O#.