Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve OmniSharp/omnisharp-roslyn#2412 #5459

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Resolve OmniSharp/omnisharp-roslyn#2412 #5459

merged 1 commit into from
Nov 16, 2022

Conversation

tvardero
Copy link
Contributor

@tvardero tvardero commented Nov 14, 2022 •
edited
Loading

This resolves OmniSharp/omnisharp-roslyn#2412

Thanks to @mcm-ham for pointing where was the issue

@tvardero
Copy link
Contributor Author

@microsoft-github-policy-service agree

@tvardero tvardero changed the title Resolve #2412 Resolve OmniSharp/omnisharp-roslyn#2412 Nov 14, 2022
dibarbet
dibarbet approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@dibarbet dibarbet merged commit 3485047 into dotnet:master Nov 16, 2022
@tvardero tvardero deleted the patch-1 branch November 17, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibarbet dibarbet dibarbet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OmniSharp.SdkInstanceProvider fails to parse 'omnisharp.sdkVersion' and 'omnisharp.sdkPath'
2 participants
@tvardero @dibarbet