-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix the extension not finding Mono #5484
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this seems good to me.
The older MSBuilds only support single dash args like -version
. The newer ones (16.10+) support both --version
and -version
so of course it makes sense to use the ones that have wider compatibility.
Tagging @333fred @JoeRobich @dibarbet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. I'll make sure this in the next release.
On Ubuntu (22.04 at least), there is also another problem: the |
@RaulPROP mono msbuild is not a subcommand of dotnet, which is what this is looking for. |
This function is only called with |
Should fix #5454