Combine test compile step into normal compile #5666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
force-pushed
the
dev/dibarbet/compile_tests
branch
4 times, most recently
from
a0d05d3
to
dd03af8
Compare
dibarbet
force-pushed
the
dev/dibarbet/compile_tests
branch
from
dd03af8
to
ed2899a
Compare
JoeRobich
approved these changes
May 3, 2023
| @@ -31,66 +31,66 @@ suite("GetOmnisharpPackage : Output package depends on the input package and oth | |||
|
|
|||
| test(`Architectures, binaries and platforms do not change useFramework: ${useFramework}`, () => { | |||
| let testPackage = inputPackages.find(element => (element.platformId && element.platformId == "os-architecture")); | |||
| let resultPackage = SetBinaryAndGetPackage(testPackage, useFramework, serverUrl, version, installPath); | |||
| let resultPackage = SetBinaryAndGetPackage(testPackage!, useFramework, serverUrl, version, installPath); | |||
There was a problem hiding this comment.
Could add a helper such as the one in this TS playground, then the compiler would be happy.
function isNotNull<T>(value: T) : asserts value is NonNullable<T> {
if (value === null || value === undefined) {
throw new Error("value is null or undefined.");
}
}There was a problem hiding this comment.
I added this, and updated all the places that I thought made sense to use it
- Places that were asserting not null using the non-annotated APIs were replaced with this function
- Places where the nullable item was used multiple times (and would have required multiple
!) I also replaced
Otherwise, I left the ! usage when the nullable item was used only once
dibarbet
force-pushed
the
dev/dibarbet/compile_tests
branch
from
7abd1d7
to
36f342b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so compile also compiles tests. There were lots of nullable warnings which I either fixed or suppressed when makes sense.
Unfortunately it looks like chai/mocha methods don't tell the TS compiler when things have been asserted to be non-null, so there are lots of
!.