Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running/debugging NUnit tests #996

Merged
merged 1 commit into from
Dec 14, 2016
Merged

Add support for running/debugging NUnit tests #996

merged 1 commit into from
Dec 14, 2016

Conversation

JPAhnen
Copy link
Contributor

@JPAhnen JPAhnen commented Nov 26, 2016

For NUnit tests, Omnisharp-Roslyn returns a new feature name
"NUnitTestMethod". When a test is executed, the test framework name must
be set (xunit or nunit). The feature name for xUnit tests did not
change.

For NUnit tests, Omnisharp-Roslyn returns a new feature name
"NUnitTestMethod". When a test is executed, the test framework name must
be set (xunit or nunit). The feature name for xUnit tests did not
change.
@dnfclas
Copy link

dnfclas commented Nov 26, 2016

Hi @HexWrench, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Nov 26, 2016

@HexWrench, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

Copy link
Member

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I'll need to take a new build of OmniSharp with OmniSharp/omnisharp-roslyn#683 before I can merge this.

@JPAhnen
Copy link
Contributor Author

JPAhnen commented Nov 28, 2016

As commented here, using this without the changes in Omnisharp-Roslyn won't break the xUnit functionality.

@DustinCampbell
Copy link
Member

I understand, but I'll wait until I've got an OmniSharp server update before pulling this into our master branch here. Once it lights up properly, I'll push a new beta release.

@DustinCampbell DustinCampbell merged commit 7faa070 into dotnet:master Dec 14, 2016
@DustinCampbell DustinCampbell added this to the 1.6 milestone Dec 14, 2016
@DustinCampbell
Copy link
Member

Sorry it took so long to get an OmniSharp server update @HexWrench. Thanks very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants