Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when x86 windows is used #998

Merged
merged 1 commit into from
Nov 28, 2016

Conversation

gregg-miskelly
Copy link
Contributor

@gregg-miskelly gregg-miskelly commented Nov 28, 2016

Previously the debugger would add an error to the install log when installing on x86 Windows. With this change we instead add a warning.

This code should be removed once #844 is fixed.

@gregg-miskelly
Copy link
Contributor Author

@chuckries please review

@gregg-miskelly gregg-miskelly merged commit 975ebe7 into dotnet:master Nov 28, 2016
@gregg-miskelly gregg-miskelly deleted the x86WindowsWarning branch November 28, 2016 19:04
WardenGnaw pushed a commit to WardenGnaw/omnisharp-vscode that referenced this pull request Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants