From 7450af1902a57f83a3bbd530babcccdc5f61ffdf Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Mon, 21 Nov 2022 15:00:19 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- onscale_client/api/files/file_util.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/onscale_client/api/files/file_util.py b/onscale_client/api/files/file_util.py index 3ab369f..e77217c 100644 --- a/onscale_client/api/files/file_util.py +++ b/onscale_client/api/files/file_util.py @@ -257,7 +257,26 @@ def tar_gunzip_file(path: str) -> List[str]: dirname = os.path.dirname(os.path.realpath(path)) with tarfile.open(path, "r:gz") as tar: files = [os.path.join(dirname, f) for f in tar.getnames()] - tar.extractall(dirname) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, dirname) return files