Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated the logo and paragraph #2

Merged
merged 2 commits into from
Jan 31, 2022
Merged

updated the logo and paragraph #2

merged 2 commits into from
Jan 31, 2022

Conversation

SAM-Aryan
Copy link
Contributor

  1. updated the logo on the hero section and in the public accessible favicon
  2. made the about section a bit shorter
  3. connected the form with the register button
  4. changed the name "ideaoryx" to "IdeaOryx"
    @dat-adi

@netlify
Copy link

netlify bot commented Jan 31, 2022 •
edited
Loading

✔️ Deploy Preview for modest-mestorf-a2c751 ready!

🔨 Explore the source changes: e04dad0

🔍 Inspect the deploy log: https://app.netlify.com/sites/modest-mestorf-a2c751/deploys/61f7ca5d7c7f94000711c05c

😎 Browse the preview: https://deploy-preview-2--modest-mestorf-a2c751.netlify.app/

dat-adi
dat-adi reviewed Jan 31, 2022
View reviewed changes
src/Loader.js
@@ -1,5 +1,5 @@
import React from 'react'
import logo from '../src/assets/Ideaoryx.svg'
import logo from '../src/assets/Ideaoryx.png'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible for you to show the output for this for different viewports?
A screenshot would be cool, because I'm not sure if a png would scale as well as an svg for this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay i will change png to svg

dat-adi
dat-adi requested changes Jan 31, 2022
View reviewed changes
Copy link
Member

@dat-adi dat-adi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes with respect to the name change look good.
There are a few issues with the changes though.

  • Check into whether the logo plays well with varying viewport sizes.
  • Get rid of either package-lock.json or yarn.lock, both of them together are unnecessary.

@SAM-Aryan SAM-Aryan requested review from SVijayB and removed request for SVijayB January 31, 2022 10:59
made minor changes
e04dad0 
- updated the ideaoryx png logo to svg
- changed project to projects in timeline file
@SAM-Aryan SAM-Aryan requested a review from dat-adi January 31, 2022 11:39
SVijayB
SVijayB approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@SVijayB SVijayB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been reviewed. Everything looks good.
Approving for a merge.

@SVijayB SVijayB merged commit 848c702 into main Jan 31, 2022
@dat-adi dat-adi deleted the timeline branch January 31, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SVijayB SVijayB SVijayB approved these changes

@dat-adi dat-adi Awaiting requested review from dat-adi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SAM-Aryan @dat-adi @SVijayB