[BUG] [DART] Using multipart/form-data breaks on File.fromJson

[freshteapot]

Bug Report Checklist

• Have you provided a full/minimal spec to reproduce the issue?
• Have you validated the input using an OpenAPI validator (example)?
• Have you tested with the latest master to confirm the issue still exists?
• Have you searched for related issues/PRs?
• What's the actual output vs expected output?
• [Optional] Sponsorship to speed up the bug fix or feature request (example)

Description

The generated code.

  HttpAssetUploadRequestBody.fromJson(Map<String, dynamic> json) {
    if (json == null) return;
    sharedWith = json['shared_with'];
    file = (json['file'] == null) ?
      null :
      File.fromJson(json['file']);
  }

The problem "fromJson" is not a method on class "File", Also "file" is "MultipartFile", which possibly means "File" should be "MultipartFile". (I am sorry for file and File).

• https://api.dart.dev/stable/2.10.0/dart-io/File-class.html
• https://pub.dev/documentation/http/latest/http/MultipartFile-class.html

openapi-generator version

openapi-generator version
4.3.1

OpenAPI declaration file content or url

It should fail with the petstore yaml file

Your more than welcome to try against

https://gist.github.com/freshteapot/2e33445c0a2f88220a156e1f61589590

Generation Details

From what I can understand using the petstore example will trigger this to happen.

Working with https://gist.github.com/freshteapot/2e33445c0a2f88220a156e1f61589590.
Use

DART_POST_PROCESS_FILE="/usr/local/bin/dartfmt -w" \
openapi-generator generate -i /tmp/openapi/one/learnalist.yaml -g dart -o /tmp/openapi/dart \
--additional-properties ensureUniqueParams=false

Related issues/PRs

Will dig up things that remotely link.

Suggest a fix

Maybe not using fromJson and just treat "file" as filename.

file, in this case is "MultipartFile". The below code compiles, not 100% sure if it works, as I haven't used the new api in my flutter app.

HttpAssetUploadRequestBody.fromJson(Map<String, dynamic> json) {
    if (json == null) return;
    sharedWith = json['shared_with'];
    file = (json['file'] == null)
        ? null
        : MultipartFile.fromString("file", json['file']);
  }

Possibly the issue is linked to

openapi-generator/modules/openapi-generator/src/main/resources/dart2/class.mustache

Lines 73 to 75 in 3f18d0f

	{{name}} = (json['{{baseName}}'] == null) ?
	null :
	{{complexType}}.fromJson(json['{{baseName}}']);

.

I suspect this might also effect toJson, as well. But at least it compiles.

[kuhnroyal]

I fixed something related to this in 5.0.0 - can you test this again?

[sergiofigueras]

Hello there @kuhnroyal ,

I had the same issue in 4.3.1 , but its now fixed in 5.0.0 .

Thanks!

[kuhnroyal]

@wing328 This can be closed