Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow API: allow dangling nodes #2803

Open
josephjclark opened this issue Jan 8, 2025 · 0 comments
Open

Workflow API: allow dangling nodes #2803

josephjclark opened this issue Jan 8, 2025 · 0 comments

Comments

@josephjclark
Copy link
Contributor

The Workflow API right now won't support dangling nodes - ie, a job node with no edges connecting to it.

This is not a real constraint in the system: the workflow diagram, the database and the runtime all support dangling nodes. Its not a problem, the node simply won't be executed.

There is no need for the Workflow API to be strict about this. It's fine at the moment for our requirements, but when migrating the workflow diagram on to the Workflow API, we'll surely need to relax this constraint.

I actually think we should generally be wiling to save invalid workflows to the database, because they may represent work-in-progress. Imagine not being able to commit to git if your linter fails (I've actually seen this in a real dev shop, it's the worst). It's up to the Workflow Diagram and the runtime (and maybe the provisioning API - although it shouldn't care too much about logical consistency) to handle any strange cases like dangling nodes.

@github-project-automation github-project-automation bot moved this to New Issues in v2 Jan 8, 2025
@josephjclark josephjclark moved this from New Issues to Backlog in v2 Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant