Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change authorization behaviour for /metrics endpoint. #2823

Closed
rorymckinley opened this issue Jan 15, 2025 · 0 comments · Fixed by #2836
Closed

Change authorization behaviour for /metrics endpoint. #2823

rorymckinley opened this issue Jan 15, 2025 · 0 comments · Fixed by #2836
Assignees

Comments

@rorymckinley
Copy link
Collaborator

Currently the /metrics endpoint uses the protection approach suggested by the author or Promex. If authorization fails, the promex plug is not loaded and a 404 is returned.

This has, so far, worked well. Recently I have encountered a potential consumer of metrics that will make the initial request sans credentials (whether using Basic or Bearer auth). It expects the host to reply with an HTTP 401 after which it will send a second request that contains the appropriate Authorization header.

This issue is to implement an alternative Authorization mechanism that will return HTTP 401 on Authorization failure.

@rorymckinley rorymckinley self-assigned this Jan 15, 2025
@github-project-automation github-project-automation bot moved this to New Issues in v2 Jan 15, 2025
@stuartc stuartc moved this from New Issues to In progress in v2 Jan 16, 2025
@rorymckinley rorymckinley moved this from In progress to In review in v2 Jan 20, 2025
@github-project-automation github-project-automation bot moved this from In review to Done in v2 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant