Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlAlchemy - upgrade + version lock + other maintenance tasks #61

Open
fpurcell opened this issue Jun 12, 2023 · 3 comments
Open

SqlAlchemy - upgrade + version lock + other maintenance tasks #61

fpurcell opened this issue Jun 12, 2023 · 3 comments
Assignees

Comments

@fpurcell
Copy link
Member

should have a versions.cfg lock file in this project
lock to latest SqlAlchemy and other deps
document any issues to upgrade to latest SqlAlchemy, if current code can't be easily up'd
cut pypi release -- new major or point version?

@fpurcell fpurcell self-assigned this Jun 12, 2023
@DeflateAwning
Copy link

Ran into the practical problems with this. I'm getting a version-related error trying to run this tool as a result of SqlAlchemy not being locked.

@hfs
Copy link

hfs commented May 7, 2024

I ran into this error with SQLAlchemy 2.0.30:

Traceback (most recent call last):
  File ".../bin/gtfsdb-load", line 5, in <module>
    from gtfsdb.scripts import gtfsdb_load
  File ".../lib/python3.11/site-packages/gtfsdb/__init__.py", line 4, in <module>
    from gtfsdb.model.agency import Agency  # noqa
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../lib/python3.11/site-packages/gtfsdb/model/agency.py", line 8, in <module>
    class Agency(Base):
  File ".../lib/python3.11/site-packages/gtfsdb/model/agency.py", line 14, in Agency
    id = Column(Integer, Sequence(None, optional=True), primary_key=True, nullable=True)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../lib/python3.11/site-packages/sqlalchemy/sql/schema.py", line 3864, in __init__
    self.name = quoted_name(name, quote)
                ^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../lib/python3.11/site-packages/sqlalchemy/sql/elements.py", line 5171, in __new__
    value is not None
AssertionError: use quoted_name.construct() for None passthrough

The workaround was to pip3 install sqlalchemy==1.4.52

@fpurcell
Copy link
Member Author

fpurcell commented May 7, 2024

hfs ... just created a few new tickets, ala #65 etc... to help resolve the SqlAlchemy version issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants