Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaymentSplitter.release uses address.transfer #2455

Closed
Amxx opened this issue Jan 6, 2021 · 1 comment · Fixed by #2456
Closed

PaymentSplitter.release uses address.transfer #2455

Amxx opened this issue Jan 6, 2021 · 1 comment · Fixed by #2456

Comments

@Amxx
Copy link
Collaborator

Amxx commented Jan 6, 2021

PaymentSplitter.release relies on the built in transfer function to sent Eth to the payee. This is bad practice, since some address need more then 2300 gas to receive funds, and should be replaced by Address:sendValue
@Amxx Amxx mentioned this issue Jan 6, 2021
Merged
frangio added a commit to Amxx/openzeppelin-contracts that referenced this issue Jan 7, 2021
@frangio
Merge branch 'master' into fix/OpenZeppelin#2455
7a99906
@frangio
Copy link
Contributor

frangio commented Jan 7, 2021

Fixed by #2456.

@frangio frangio closed this as completed Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Address.sendValue for PaymentSplitter Amxx/openzeppelin-contracts
2 participants
@frangio @Amxx