Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for EIP2098 "short signatures" in the ECDSA library #2582

Merged
merged 15 commits into from
Apr 9, 2021
Merged

Add support for EIP2098 "short signatures" in the ECDSA library #2582

merged 15 commits into from
Apr 9, 2021

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Mar 12, 2021 •
edited
Loading

Fixes #2539

PR Checklist

  • Tests
  • Changelog entry

@Amxx Amxx changed the title Feature/eip 2098 Add support for EIP2098 "short signatures" in the ECDSA library Mar 12, 2021
@Amxx Amxx requested a review from frangio March 15, 2021 10:00
@frangio
Copy link
Contributor

frangio commented Mar 16, 2021 •
edited
Loading

Waiting for a reply about the EIP becoming Final. ethereum/EIPs#2440 (comment)

@Amxx Amxx force-pushed the feature/eip-2098 branch from 83f1c42 to f9b792d Compare March 23, 2021 15:30
@frangio
Copy link
Contributor

frangio commented Apr 6, 2021

We've decided to move forward with this PR even though the corresponding EIP is a Draft because we don't see how it could change in a backwards incompatible way, and it seems to be on the path to be Finalized.

frangio
frangio reviewed Apr 6, 2021
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge after my comments here are addressed.

test/utils/cryptography/ECDSA.test.js Outdated Show resolved Hide resolved
test/utils/cryptography/ECDSA.test.js Outdated Show resolved Hide resolved
contracts/utils/cryptography/ECDSA.sol Outdated Show resolved Hide resolved
test/utils/cryptography/ECDSA.test.js Outdated Show resolved Hide resolved
test/utils/cryptography/ECDSA.test.js Outdated Show resolved Hide resolved
test/utils/cryptography/ECDSA.test.js Outdated Show resolved Hide resolved
@frangio
Copy link
Contributor

frangio commented Apr 7, 2021

There should be some documentation about the format of the signature argument. We don't even have documentation for the long format...

frangio
frangio approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@frangio frangio enabled auto-merge (squash) April 9, 2021 22:52
@frangio frangio merged commit 555be63 into OpenZeppelin:master Apr 9, 2021
@Amxx Amxx deleted the feature/eip-2098 branch April 10, 2021 20:08
@Amxx Amxx mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for EIP2098 "short signatures" in the ECDSA library
2 participants
@Amxx @frangio