refactor(ERC165Checker) replaced assembly code with staticcall() #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yopereir
changed the title
|
@yopereir The problem is that with |
frangio
reviewed
Jul 29, 2019
yopereir
force-pushed
the
refactor/replaceAssembly#1761
branch
from
b36d7c6 to
f9066ad
Compare
…ts into refactor/replaceAssembly#1761
|
Thanks @yopereir! I'm holding off on merging this for a few more weeks, to give Solidity 0.5.10 a little bit of time to mature. |
frangio
added
the
on hold
|
ok |
|
Given that 0.5.11 has already come out, I think we can resume this. |
nventuro
removed
the
on hold
frangio
reviewed
Sep 11, 2019
| result := mload(output) // Load the result | ||
| } | ||
| (bool success, bytes memory result) = account.staticcall.gas(30000)(encodedParams); | ||
| if (result.length == 0) return (false, false); |
There was a problem hiding this comment.
Just in case, I think we should change this to make sure we're replicating the exact same behavior as before. Otherwise abi.decode could fail.
Suggested change
| if (result.length == 0) return (false, false); | |
| if (result.length < 32) return (false, false); |
|
Thanks @yopereir! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1761
Replaced assembly code in ERC165Checker with
staticcallmethod