[PaddlePaddle Hackathon] Added CIRCULAR mode to pad in ngraph #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PFC document is in the zip file. The password of zip file will be send to PaddlePaddle Hackathon Team by e-mail.
|
您好，功能实现上看上去没有什么问题。但建议您考虑下如何用一个统一的基类，复用v1版本的实现。可以参考gather算子。 |
确实统一基类的形式更合理，当时也考虑过，只不过为了开发速度选择了目前的形式。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets:
PR types
New features
PR changes
pad operator in ngraph
Describe
Task: openvinotoolkit#7611
Added CIRCULAR mode to pad in ngraph.
In opset v8, pad will support the mew mode.
UT test cases passed.
UT Result