Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2 support relies on deprecated function #258

Closed
vladmandic opened this issue Jul 2, 2020 · 1 comment
Closed

http2 support relies on deprecated function #258

vladmandic opened this issue Jul 2, 2020 · 1 comment

Comments

@vladmandic
Copy link

vladmandic commented Jul 2, 2020

Enabling http2 in Redbird causes runtime warning:

(node:56863) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated
at ServerResponse.writeHead (/home/vlado/dev/piproxy/node_modules/spdy/lib/spdy/response.js:18:12)
at ServerResponse._implicitHeader (http_server.js:240:8)
at write
(_http_outgoing.js:660:9)
at ServerResponse.write (_http_outgoing.js:636:15)
at IncomingMessage.ondata (_stream_readable.js:712:22)
at IncomingMessage.emit (events.js:315:20)
at IncomingMessage.Readable.read (_stream_readable.js:512:10)
at flow (stream_readable.js:985:34)
at resume
(_stream_readable.js:966:3)
at processTicksAndRejections (internal/process/task_queues.js:84:21)

Which is caused by a known spdy issue:
[(https://github.com/spdy-http2/node-spdy/issues/366)]

given that nodejs nowadays supports http2 natively, I think depencency on spdy is no longer needed.

@vladmandic
Copy link
Author

closing as no update from maintainer for over a year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant