Add Django 5.1 compatibility to MigrationAutodetectorMixin #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfouque
commented
Aug 21, 2024
Comment on lines
+9
to
+10
| py{310,311,312}-django51-psycopg2 | ||
| py312-django51-psycopg3 |
There was a problem hiding this comment.
Extracted from AmbitionEng/python-library-template#21
|
@pfouque thanks for the change! Im surprised the test suite doesn't fail for 5.1. Let me get an upgrade into pgtrigger first, then I'll merge this, and then I'll see if I can accompany this with a failing test. Should have this released today |
|
Nvm the test suite did catch this. You are right that I should just be testing against the main branch. I will look into adding that into the testing matrix. Thanks again for the fix. Will report back when this is deployed |
|
Thanks @wesleykendall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to #148 I managed to find a fix to make pg-trigger compatible with Django 5.1
NB: It would be nice to add Django "main" version to the testing grid so that issue are discovered soon enough before the official releases