Account for sql.SQL and sql.Composed Objects
#177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-muoto
commented
Sep 29, 2024
pgtrigger/tests/test_runtime.py
Outdated
| (b"select count(*) from auth_user", ()), | ||
| ("select count(*) from auth_user where id = %s", (1,), 2), | ||
| ("select count(*) from auth_user", (), 2), | ||
| (b"select count(*) from auth_user where id = %s", (1,), 2), |
There was a problem hiding this comment.
It makes sense to run these on 3 as the query can still technically be bytes. See https://github.com/psycopg/psycopg/blob/master/psycopg/psycopg/abc.py#L30
max-muoto
commented
Sep 29, 2024
pgtrigger/tests/test_runtime.py
Outdated
| from unittest.mock import MagicMock | ||
|
|
||
| SQL = MagicMock() | ||
| Literal = MagicMock() |
There was a problem hiding this comment.
Just to avoid the parameterization failing on 3.
…o fix-pgtrigger-ignore-issues
wesleykendall
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
sql.SQLandsql.Composedobjects, which are valid ways to construct SQL expressions within Psycopg 2 and 3.