-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed breaking typing_extensions import #181
Removed breaking typing_extensions import #181
Conversation
Seems like mypy might require this package so I don't think it can be removed. |
When you say "breaking", do you mean the code causes an error in Python 3.12? Do you not have I verified that I can I will defer this one to @max-muoto , but the better approach is probably conditionally installing |
Yes, exactly so when installing this as a dependency typing-extensions is not installed on 3.11 or 3.12 as it requires < 3.11 https://github.com/BillSchumacher/django-audimatic/actions/runs/11563973687/job/32188306870 |
Either way I'm not sure that the import is actually needed. |
Do you think you could try moving the import under an from typing import TYPE_CHECKING
if TYPE_CHECKING:
from typing_extensions import Self The import is mainly needed for those relying on static type-checkers such as Pyright or MyPy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @BillSchumacher. Can merge this and bump the version. |
@BillSchumacher this is being released in v4.13.0, thanks! |
Resolves #180