-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated keyword HTTP/* for HTTP #3704
Remove deprecated keyword HTTP/* for HTTP #3704
Conversation
Hi @nghiab1906724 I don't see any rust code modified in this PR, do I miss something? |
Hello @jcamiel , |
Hi @jcamiel , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR there are small changes to address. Could you please also rebase and squash the 2 commits to only one commit,
Thanks!
Hi @jcamiel , I have made changes based on your comments. I’ve removed "integration/hurl/tests_ok/deprecated.hurl" and fixed the related issues. Could you help me review it? Thanks! |
@nghiab1906724 everythings looks good now. As there are some integration tests that have changed, you have to change the expected output files also . For instance, the CI/CD checks the result of |
All tests are OK @nghiab1906724 you can rebase, squash and it should be good! |
7631ed8
to
8747cd1
Compare
Hi @jcamiel , |
/accept |
🕗 /accept is running, please wait for completion. |
🔨 Auto rebase from
|
🕗 /accept is still running, please wait for completion. |
8747cd1
to
6c34178
Compare
❌ Some checks are still failing, please fix them before trying to merge this pull request. |
/accept |
🕗 /accept is running, please wait for completion. |
✅ Pull request merged with fast forward by
|
No description provided.