Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated keyword HTTP/* for HTTP #3704

Merged

Conversation

nghiab1906724
Copy link
Contributor

No description provided.

@jcamiel
Copy link
Collaborator

jcamiel commented Feb 6, 2025

Hi @nghiab1906724 I don't see any rust code modified in this PR, do I miss something?

@nghiab1906724
Copy link
Contributor Author

Hello @jcamiel ,
I apologize for this issue. I will add the missing code shortly.
Thank you so much!!!

@nghiab1906724
Copy link
Contributor Author

Hi @jcamiel ,
I’ve just removed the deprecated HTTP/* keyword from the Rust code as requested.
Could you kindly review the changes?
Thank you for your support!

Copy link
Collaborator

@jcamiel jcamiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nghiab1906724

Thanks for the PR there are small changes to address. Could you please also rebase and squash the 2 commits to only one commit,

Thanks!

integration/hurl/tests_ok/deprecated.hurl Outdated Show resolved Hide resolved
integration/hurlfmt/tests_export/http_version.hurl Outdated Show resolved Hide resolved
integration/hurlfmt/tests_export/http_version.lint.hurl Outdated Show resolved Hide resolved
@nghiab1906724
Copy link
Contributor Author

Hi @jcamiel ,

I have made changes based on your comments. I’ve removed "integration/hurl/tests_ok/deprecated.hurl" and fixed the related issues.

Could you help me review it?
If everything works well, I will rebase and squash the commits into a single commit.

Thanks!

@jcamiel
Copy link
Collaborator

jcamiel commented Feb 7, 2025

@nghiab1906724 everythings looks good now. As there are some integration tests that have changed, you have to change the expected output files also . For instance, the CI/CD checks the result of hurlfmt --out json tests_export/http_version.hurl; as http_version.hurl` has changed we have to update it also. You can find more information on the integration test here => https://github.com/Orange-OpenSource/hurl/blob/master/RELEASING.md

@jcamiel jcamiel linked an issue Feb 7, 2025 that may be closed by this pull request
@jcamiel
Copy link
Collaborator

jcamiel commented Feb 7, 2025

All tests are OK @nghiab1906724 you can rebase, squash and it should be good!

@nghiab1906724 nghiab1906724 force-pushed the remove-deprecated-keyword branch from 7631ed8 to 8747cd1 Compare February 7, 2025 22:30
@nghiab1906724
Copy link
Contributor Author

Hi @jcamiel ,
I’ve just rebased and squashed. Could you help me check?
Thank you so much!

@jcamiel
Copy link
Collaborator

jcamiel commented Feb 7, 2025

/accept

@hurl-bot
Copy link
Collaborator

hurl-bot commented Feb 7, 2025

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

hurl-bot commented Feb 7, 2025

🔨 Auto rebase from Orange-OpenSource/hurl/master succeeds, nghiab1906724/hurl/remove-deprecated-keyword now embeds these commits:

  • 844c23d Fix hurlfmt panicking when pipe is broken, instead should exist with formatted error message and status code != 0
  • 195abfc fix invalid escape in hurlfmt parse func
  • 0fb5030 add ip to asserts
  • e41abb0 rename ip module
  • c4bdea4 Update actions
  • 37550ea Fix cookie expire computation change with curl 8.12.0.
  • 8dd8451 Update to Rust 1.84.1

@hurl-bot
Copy link
Collaborator

hurl-bot commented Feb 7, 2025

🕗 /accept is still running, please wait for completion.

@hurl-bot hurl-bot force-pushed the remove-deprecated-keyword branch from 8747cd1 to 6c34178 Compare February 7, 2025 23:18
@hurl-bot
Copy link
Collaborator

hurl-bot commented Feb 7, 2025

❌ Some checks are still failing, please fix them before trying to merge this pull request.

@jcamiel
Copy link
Collaborator

jcamiel commented Feb 8, 2025

/accept

@hurl-bot
Copy link
Collaborator

hurl-bot commented Feb 8, 2025

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

hurl-bot commented Feb 8, 2025

✅ Pull request merged with fast forward by jcamiel..

# List of commits merged from nghiab1906724/hurl/remove-deprecated-keyword branch into Orange-OpenSource/hurl/master branch:

  • 6c34178 Remove deprecated keyword HTTP/* for HTTP

@hurl-bot hurl-bot merged commit 6c34178 into Orange-OpenSource:master Feb 8, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated keyword HTTP/* for HTTP
3 participants