-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating to JQuery 3.6.0 #8525
Comments
Working on this, we found the the gulp pipeline is broken. |
If I remember correctly, Orchard used to use BundlerMinifier and got migrated to the gulp pipeline because we could fine-tune it more. There are also dependencies that only need to be copied without getting bundled so the gulp pipeline can also do that. Moving back to the BundlerMinifier won't fix the deprecated dependencies issue either. So, I believe this would be more regression than anything. I would try to fix the npm packages and dependencies before anything else. Because in the end, that's what's needed. |
Thanks @Skrypt for clarifying why gulp was choosen. |
What would need to be done is to use the latest LTS version of Node.js + npm and update the packages.json files up until no package deprecated are found. After that, test things manually in OC to make sure the components are still working. Because it can "transpile" without necessarily working. That's why I said earlier that normally using the Node.js version that was used back then to transpile everything should be the easiest way to make it transpile and work. |
Also as part of being able to do reproducible builds, I think we should document the version of Node.js used to transpile the Gulp pipeline to avoid having this situation again in a few years. The recommendation is good for Orchard Core too. |
For dev branch, we will update JQuery to its latest stable release (3.6.0.)
The text was updated successfully, but these errors were encountered: