Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-evaluate use CreateModelMaybeAsync (OCC-280) #479

Closed
MikeAlhayek opened this issue Aug 6, 2024 · 2 comments
Closed

Re-evaluate use CreateModelMaybeAsync (OCC-280) #479

MikeAlhayek opened this issue Aug 6, 2024 · 2 comments
Assignees
@sarahelsaig
Labels
bug Something isn't working

Comments

@MikeAlhayek
Copy link
Member

MikeAlhayek commented Aug 6, 2024 •
edited by github-actions bot
Loading

Suggestion based on quick review of code. The method CreateModelMaybeAsync should no longer be used

More about the reasoning can be found here

Jira issue
@MikeAlhayek MikeAlhayek added the bug Something isn't working label Aug 6, 2024
@github-actions github-actions bot changed the title Remove the use CreateModelMaybeAsync Remove the use CreateModelMaybeAsync (OCC-280) Aug 6, 2024
@sarahelsaig
Copy link
Contributor

When the driver is converted from SectionDisplayDriver to SiteDisplayDriver, the groupId parameter may be removed (set to null) in the method call. No other action is necessary.

@sarahelsaig sarahelsaig changed the title Remove the use CreateModelMaybeAsync (OCC-280) Re-evaluate use CreateModelMaybeAsync (OCC-280) Aug 9, 2024
@github-actions github-actions bot mentioned this issue Aug 9, 2024
Merged
@sarahelsaig
Copy link
Contributor

This was done by #482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarahelsaig sarahelsaig

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sarahelsaig @MikeAlhayek