Fixes #2879 (#3077)

OrchardCMS · Jan 22, 2019 · c39faf3 · c39faf3
1 parent e16bb08
commit c39faf3
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 6 deletions.
diff --git a/src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/GraphQLMiddleware.cs b/src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/GraphQLMiddleware.cs
@@ -164,10 +164,7 @@ private async Task ExecuteAsync(HttpContext context, ISchemaFactory schemaServic
                 _.OperationName = request.OperationName;
                 _.Inputs = request.Variables.ToInputs();
                 _.UserContext = _settings.BuildUserContext?.Invoke(context);
-
-#if DEBUG
-                _.ExposeExceptions = true;
-#endif
+                _.ExposeExceptions = _settings.ExposeExceptions;
             });
 
             var httpResult = result.Errors?.Count > 0

diff --git a/src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/GraphQLSettings.cs b/src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/GraphQLSettings.cs
@@ -7,5 +7,6 @@ public class GraphQLSettings
     {
         public PathString Path { get; set; } = "/api/graphql";
         public Func<HttpContext, object> BuildUserContext { get; set; }
+        public bool ExposeExceptions = false;
     }
 }
diff --git a/src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/Startup.cs b/src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/Startup.cs
@@ -3,6 +3,7 @@
 using GraphQL.Http;
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Routing;
+using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using OrchardCore.Apis.GraphQL.Services;
 using OrchardCore.Modules;
@@ -13,6 +14,13 @@ namespace OrchardCore.Apis.GraphQL
 {
     public class Startup : StartupBase
     {
+        private IConfiguration _configuration;
+
+        public Startup(IConfiguration configuration)
+        {
+            _configuration = configuration;
+        }
+
         public override void ConfigureServices(IServiceCollection services)
         {
             services.AddSingleton<IDependencyResolver, RequestServicesDependencyResolver>();
@@ -27,13 +35,20 @@ public override void ConfigureServices(IServiceCollection services)
 
         public override void Configure(IApplicationBuilder app, IRouteBuilder routes, IServiceProvider serviceProvider)
         {
+#if DEBUG
+            var exposeExceptions = _configuration.GetValue<bool>($"Modules:OrchardCore.Apis.GraphQL:{nameof(GraphQLSettings.ExposeExceptions)}", true);
+#else
+            var exposeExceptions = _configuration.GetValue<bool>($"Modules:OrchardCore.Apis.GraphQL:{nameof(GraphQLSettings.ExposeExceptions)}", false);
+#endif
+
             app.UseMiddleware<GraphQLMiddleware>(new GraphQLSettings
             {
                 BuildUserContext = ctx => new GraphQLContext
                 {
                     User = ctx.User,
-                    ServiceProvider = ctx.RequestServices
-                }
+                    ServiceProvider = ctx.RequestServices,
+                },
+                ExposeExceptions = exposeExceptions
             });
         }
     }