sort filter doesn't handle null value in 1.0 unlike RC2

[dodyg]

This sort field

generates

   at System.Decimal.CompareTo(Object value)

   at System.Linq.EnumerableSorter`2.CompareAnyKeys(Int32 index1, Int32 index2)

   at System.Collections.Generic.ArraySortHelper`1.SwapIfGreater(T[] keys, Comparison`1 comparer, Int32 a, Int32 b)

   at System.Collections.Generic.ArraySortHelper`1.PickPivotAndPartition(T[] keys, Int32 lo, Int32 hi, Comparison`1 comparer)

   at System.Collections.Generic.ArraySortHelper`1.IntroSort(T[] keys, Int32 lo, Int32 hi, Int32 depthLimit, Comparison`1 comparer)

   at System.Collections.Generic.GenericArraySortHelper`1.Sort(T[] keys, Int32 index, Int32 length, IComparer`1 comparer)

InvalidOperationException: Failed to compare two elements in the array.

    System.Collections.Generic.GenericArraySortHelper<T>.Sort(T[] keys, int index, int length, IComparer<T> comparer)
    System.Array.Sort<T>(T[] array, int index, int length, IComparer<T> comparer)
    System.Linq.EnumerableSorter<TElement>.Sort(TElement[] elements, int count)
    System.Linq.OrderedEnumerable<TElement>.GetEnumerator()+MoveNext()
    System.Linq.Enumerable+SelectIPartitionIterator<TSource, TResult>.PreallocatingToArray(int count)
    Fluid.Filters.ArrayFilters.Sort(FluidValue input, FilterArguments arguments, TemplateContext context)
    Fluid.Ast.FilterExpression.EvaluateAsync(TemplateContext context)
    System.Threading.Tasks.ValueTask<TResult>.get_Result()
    Fluid.Ast.AssignStatement.<WriteToAsync>g__Awaited|7_0(ValueTask<FluidValue> task, TemplateContext context, string identifier)
    Fluid.Ast.ForStatement.WriteToAsync(TextWriter writer, TextEncoder encoder, TemplateContext context)
    Fluid.Parser.FluidTemplate.Awaited(ValueTask<Completion> task, TextWriter writer, TextEncoder encoder, TemplateContext context, IReadOnlyList<Statement> statements, int startIndex)
    Fluid.FluidTemplateExtensions.<RenderAsync>g__Awaited|3_0(ValueTask task, StringWriter writer, StringBuilderPool builder)
    OrchardCore.DisplayManagement.Liquid.LiquidViewTemplateExtensions.RenderAsync(LiquidViewTemplate template, TextEncoder encoder, LiquidTemplateContext context, object model)
    OrchardCore.Liquid.Filters.LiquidFilter.ProcessAsync(FluidValue input, FilterArguments arguments, LiquidTemplateContext ctx)
    Fluid.Ast.FilterExpression.EvaluateAsync(TemplateContext context)
    System.Threading.Tasks.ValueTask<TResult>.get_Result()
    Fluid.Ast.OutputStatement.<WriteToAsync>g__Awaited|7_0(ValueTask<FluidValue> t, TextWriter w, TextEncoder enc, TemplateContext ctx)
    Fluid.Parser.FluidTemplate.Awaited(ValueTask<Completion> task, TextWriter writer, TextEncoder encoder, TemplateContext context, IReadOnlyList<Statement> statements, int startIndex)
    OrchardCore.DisplayManagement.Liquid.LiquidViewTemplateExtensions.RenderAsync(LiquidViewTemplate template, TextWriter writer, TextEncoder encoder, LiquidTemplateContext context, object model)
    OrchardCore.Liquid.Services.LiquidTemplateManager.RenderHtmlContentAsync(string source, TextEncoder encoder, object model, IEnumerable<KeyValuePair<string, FluidValue>> properties)
    OrchardCore.Templates.Services.TemplatesShapeBindingResolver+<>c__DisplayClass8_0+<<BuildShapeBinding>b__0>d.MoveNext()
    OrchardCore.DisplayManagement.Implementation.DefaultHtmlDisplay.<ProcessAsync>g__Awaited|11_0(Task<IHtmlContent> task)
    OrchardCore.DisplayManagement.Implementation.DefaultHtmlDisplay.ExecuteAsync(DisplayContext context)
    OrchardCore.DisplayManagement.Implementation.DefaultHtmlDisplay.ExecuteAsync(DisplayContext context)
    CallSite.Target(Closure , CallSite , object )
    AspNetCore._Areas_OrchardCore_Contents_Views_Item_Display.ExecuteAsync() in Display.cshtml

    @await DisplayAsync(Model)

Microsoft.AspNetCore.Mvc.Razor.RazorView.RenderPageCoreAsync(IRazorPage page, ViewContext context)
Microsoft.AspNetCore.Mvc.Razor.RazorView.RenderPageAsync(IRazorPage page, ViewContext context, bool invokeViewStarts)
Microsoft.AspNetCore.Mvc.Razor.RazorView.RenderAsync(ViewContext context)
Microsoft.AspNetCore.Mvc.ViewFeatures.ViewExecutor.ExecuteAsync(ViewContext viewContext, string contentType, Nullable<int> statusCode)
Microsoft.AspNetCore.Mvc.ViewFeatures.ViewExecutor.ExecuteAsync(ViewContext viewContext, string contentType, Nullable<int> statusCode)
Microsoft.AspNetCore.Mvc.ViewFeatures.ViewExecutor.ExecuteAsync(ActionContext actionContext, IView view, ViewDataDictionary viewData, ITempDataDictionary tempData, string contentType, Nullable<int> statusCode)
Microsoft.AspNetCore.Mvc.ViewFeatures.ViewResultExecutor.ExecuteAsync(ActionContext context, ViewResult result)
Microsoft.AspNetCore.Mvc.ViewResult.ExecuteResultAsync(ActionContext context)
Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeNextResultFilterAsync>g__Awaited|29_0<TFilter, TFilterAsync>(ResourceInvoker invoker, Task lastTask, State next, Scope scope, object state, bool isCompleted)
Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResultExecutedContextSealed context)
Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.ResultNext<TFilter, TFilterAsync>(ref State next, ref Scope scope, ref object state, ref bool isCompleted)
Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeResultFilters()
Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeNextResourceFilter>g__Awaited|24_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, object state, bool isCompleted)
Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResourceExecutedContextSealed context)
Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next(ref State next, ref Scope scope, ref object state, ref bool isCompleted)
Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeFilterPipelineAsync()
Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Awaited|17_0(ResourceInvoker invoker, Task task, IDisposable scope)
Microsoft.AspNetCore.Routing.EndpointMiddleware.<Invoke>g__AwaitRequestTask|6_0(Endpoint endpoint, Task requestTask, ILogger logger)
SixLabors.ImageSharp.Web.Middleware.ImageSharpMiddleware.Invoke(HttpContext context)
Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
Microsoft.AspNetCore.Localization.RequestLocalizationMiddleware.Invoke(HttpContext context)
OrchardCore.Diagnostics.DiagnosticsStartupFilter+<>c__DisplayClass3_0+<<Configure>b__1>d.MoveNext()
Microsoft.AspNetCore.Diagnostics.StatusCodePagesMiddleware.Invoke(HttpContext context)
OrchardCore.ContentPreview.PreviewStartupFilter+<>c+<<Configure>b__1_1>d.MoveNext()
OrchardCore.Modules.ModularTenantRouterMiddleware.Invoke(HttpContext httpContext)
OrchardCore.Logging.SerilogTenantNameLoggingMiddleware.Invoke(HttpContext context)
OrchardCore.Modules.ModularTenantContainerMiddleware+<>c__DisplayClass4_0+<<Invoke>b__0>d.MoveNext()
OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func<ShellScope, Task> execute, bool activateShell)
OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func<ShellScope, Task> execute, bool activateShell)
OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func<ShellScope, Task> execute, bool activateShell)
OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func<ShellScope, Task> execute, bool activateShell)
OrchardCore.Modules.ModularTenantContainerMiddleware.Invoke(HttpContext httpContext)
Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

[dodyg]

This field is optional

[dodyg]

If I remove the sort, the page works

[Skrypt]

I'm not aware of any sort liquid filter. Normally this "sort" should be passed as a Query param so try replace the | in from of the "sort" param with a column ",".

Also, try to share your Query so that we can understand the whole context.

[dodyg]

This is Liquid sort https://shopify.github.io/liquid/filters/sort/

[Skrypt]

Ok, makes sense then. 👍🏼

[hishamco]

Does one of the Order.Values contains null or empty?

[Skrypt]

In his example he pass a fixed string value.

[hishamco]

This is a value to be ordered if I'm not wrong

[Skrypt]

Yeha like on a Lucene Query where you define a name of the column to sort/order by.