You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm fine with or without any editor rule, the goal being to just need to say please fix analyzer messages, but I saw too many PR comments around this, so we are missing rules and/or some comments are not relevant, my bad I did the same at some point ;)
About comments, personnaly I prefer to start with an uppercase and have a dot at the end, but I'm totally fine without these rules, because I worked with these rules, my bad at some point I polluted some PRs.
but what I don't like is //some comments without a leading space, fortunately this is part of our rules, so all good for me unless we want to add the starting Uppercase and ending Dot rules.
About blank lines to separate code, I agree after the ending brace of a block, when the declaration of a var or a property or a method takes more than one line, in itself or because of a comment or doc, and so on.
But not everywhere, when the code is too evenly spaced it's beautiful but for me not the best for readability, I prefer to have some groups of related things, for example not force to separate each class member if in one line without comment, or as said only separate some groups.
Also with variables and code blocks, for example I now prefer this
var test1 = ...
If (test1 == ...)
{
]
var test2 = ...
If (test2 == ...)
{
]
Than that
var test1 = ...
If (test1 == ...)
{
]
var test2 = ...
If (test2 == ...)
{
]
I think we should add the rules to use blocks with braces and to add an empty line after the ending brace of any code block (may be contradictory with group separations), but again I can live without them.
Maybe many other rules to discuss but here the first ones I'm thinking about, as said the goal being to just have to say to someone please fix the analyzer messages and under Visual Studio also say, ctrl+K+D for formatting and ctrl+R+G to cleanup usings.
I don't talk about spell checking from which I learnt that Protector is not a word, but for now I kept it ;)
Again I'm fine with or without any editor rule, but I saw too many PR comments only around this, so we are missing editor rules and/or we should reduce some comments, my bad I did the same at some point ;)
I agree we could define some recommendations (only) but not sure that it would be easy to manage.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I'm fine with or without any editor rule, the goal being to just need to say
please fix analyzer messages
, but I saw too many PR comments around this, so we are missing rules and/or some comments are not relevant, my bad I did the same at some point ;)About comments, personnaly I prefer to start with an uppercase and have a dot at the end, but I'm totally fine without these rules, because I worked with these rules, my bad at some point I polluted some PRs.
but what I don't like is
//some comments
without a leading space, fortunately this is part of our rules, so all good for me unless we want to add the starting Uppercase and ending Dot rules.About blank lines to separate code, I agree after the ending brace of a block, when the declaration of a var or a property or a method takes more than one line, in itself or because of a comment or doc, and so on.
But not everywhere, when the code is too evenly spaced it's beautiful but for me not the best for readability, I prefer to have some groups of related things, for example not force to separate each class member if in one line without comment, or as said only separate some groups.
Also with variables and code blocks, for example I now prefer this
Than that
I think we should add the rules to use blocks with braces and to add an empty line after the ending brace of any code block (may be contradictory with group separations), but again I can live without them.
Maybe many other rules to discuss but here the first ones I'm thinking about, as said the goal being to just have to say to someone
please fix the analyzer messages
and under Visual Studio also say,ctrl+K+D
for formatting andctrl+R+G
to cleanup usings.I don't talk about spell checking from which I learnt that
Protector
is not a word, but for now I kept it ;)Again I'm fine with or without any editor rule, but I saw too many PR comments only around this, so we are missing editor rules and/or we should reduce some comments, my bad I did the same at some point ;)
I agree we could define some recommendations (only) but not sure that it would be easy to manage.
Beta Was this translation helpful? Give feedback.
All reactions