Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications are hard to read in dark mode due to low contrast #10796

Closed
0liver opened this issue Dec 2, 2021 · 8 comments · Fixed by #9371
Closed

Notifications are hard to read in dark mode due to low contrast #10796

0liver opened this issue Dec 2, 2021 · 8 comments · Fixed by #9371
Milestone

Comments

@0liver
Copy link
Contributor

0liver commented Dec 2, 2021

Describe the bug

In dark mode, the notification text is quite hard to read on the green background - see below.

To Reproduce

Steps to reproduce the behavior:

  1. Turn on dark mode (I don't know where, maybe it's a browser setting?).
  2. Go to the Admin dashboard.
  3. Look at the Welcome message.

Expected behavior

An easily readable message text.

Screenshots

If applicable, add screenshots to help explain your problem.

image

The contrast ratio is 2.76:1, which does not sound too bad, but in combination with the font it actually appears worse than e.g. in this online tool here:

image

@Skrypt
Copy link
Contributor

Skrypt commented Dec 2, 2021

We have a PR for Bootstrap 5 where it should be fixed. Feel free to contribute there.

@0liver
Copy link
Contributor Author

0liver commented Dec 2, 2021

Could you please link that PR here?

@Skrypt
Copy link
Contributor

Skrypt commented Dec 2, 2021

#9371

So basically, create a PR targetting that PR branch.

@0liver
Copy link
Contributor Author

0liver commented Dec 3, 2021

That PR is for using Bootstrap 5 in the Admin area. But notifications are shown in the frontend as well, and there, Bootstrap 5.1 is already integrated from what I saw in the commits between 1.0 and 1.1.

And while I would like to submit a PR, I really don't have any idea of OC's design system, so it would be hard for me to suggest something that will work in the broader context.

@Skrypt
Copy link
Contributor

Skrypt commented Dec 3, 2021

The frontend themes have their own thing so it's another topic.

Here, you just need to modify the text color for when we are in the dark mode. I will take a look as part of #9371 then.

@Skrypt Skrypt mentioned this issue Dec 3, 2021
29 tasks
@sebastienros sebastienros added this to the 1.x milestone Dec 9, 2021
@Skrypt
Copy link
Contributor

Skrypt commented Jan 7, 2022

Fixed in #9371

image

@hishamco
Copy link
Member

hishamco commented Jan 7, 2022

Could you please link this issue into Bootstrap PR or mention it in the description, so when the PR is merged it should be closed automatically

@Skrypt
Copy link
Contributor

Skrypt commented Jan 7, 2022

It is already linked look at the right panel here.

@sebastienros sebastienros modified the milestones: 1.x, 1.4 Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants