-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications are hard to read in dark mode due to low contrast #10796
Comments
We have a PR for Bootstrap 5 where it should be fixed. Feel free to contribute there. |
Could you please link that PR here? |
So basically, create a PR targetting that PR branch. |
That PR is for using Bootstrap 5 in the Admin area. But notifications are shown in the frontend as well, and there, Bootstrap 5.1 is already integrated from what I saw in the commits between 1.0 and 1.1. And while I would like to submit a PR, I really don't have any idea of OC's design system, so it would be hard for me to suggest something that will work in the broader context. |
The frontend themes have their own thing so it's another topic. Here, you just need to modify the text color for when we are in the dark mode. I will take a look as part of #9371 then. |
Fixed in #9371 |
Could you please link this issue into Bootstrap PR or mention it in the description, so when the PR is merged it should be closed automatically |
It is already linked look at the right panel here. |
Describe the bug
In dark mode, the notification text is quite hard to read on the green background - see below.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
An easily readable message text.
Screenshots
If applicable, add screenshots to help explain your problem.
The contrast ratio is 2.76:1, which does not sound too bad, but in combination with the font it actually appears worse than e.g. in this online tool here:
The text was updated successfully, but these errors were encountered: