-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CodeMirror 5.65.2 SRI hashes are wrong #11646
Comments
For some reason sometimes it happens. /cc @agriffard |
I'm not sure if we should keep using the Codemirror editor now while we have the Monaco one. |
FYI this is working correctly in the main branch which is using CodeMirror 5.65.3. |
We had issues where the SRI hashes changed for some reason as reported by @agriffard. I suggest that we do a PR and then release a 1.3.1 version with the patch as this is pretty important that it works. |
Good thing we need to ship 1.4 Also, who wants to create a build step that verifies all the resources we have we shas on the CI? |
It could be a unit test, since we can fake the services, resolve all resource, and download them this way. |
Related to #11580 |
This is also causing #11388 |
I already did a PR long time for, that using source genrators, I think I need to continue work on it to avoid such SHA inconsistency |
Describe the bug
In OC 1.3 the codemirror.cs and codemirror.js files are failing the integrity check. It looks like the version may have been updated without also updating the SRI hashes.
To Reproduce
Steps to reproduce the behavior:
Screenshots
The text was updated successfully, but these errors were encountered: