Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeMirror 5.65.2 SRI hashes are wrong #11646

Closed
rjpowers10 opened this issue May 5, 2022 · 9 comments · Fixed by #11580
Closed

CodeMirror 5.65.2 SRI hashes are wrong #11646

rjpowers10 opened this issue May 5, 2022 · 9 comments · Fixed by #11580
Milestone

Comments

@rjpowers10
Copy link
Contributor

Describe the bug

In OC 1.3 the codemirror.cs and codemirror.js files are failing the integrity check. It looks like the version may have been updated without also updating the SRI hashes.

To Reproduce

Steps to reproduce the behavior:

  1. Create a new OC 1.3 site using the blog theme
  2. Check "Use framework CDN" at Admin/Settings/general
  3. Edit the AutoroutePart settings for a BlogPost at Admin/ContentTypes/BlogPost/ContentParts/AutoroutePart/Edit

Screenshots

image

image

@Skrypt
Copy link
Contributor

Skrypt commented May 5, 2022

For some reason sometimes it happens.

/cc @agriffard

@Skrypt
Copy link
Contributor

Skrypt commented May 5, 2022

I'm not sure if we should keep using the Codemirror editor now while we have the Monaco one.

@rjpowers10
Copy link
Contributor Author

FYI this is working correctly in the main branch which is using CodeMirror 5.65.3.

@Skrypt
Copy link
Contributor

Skrypt commented May 5, 2022

We had issues where the SRI hashes changed for some reason as reported by @agriffard. I suggest that we do a PR and then release a 1.3.1 version with the patch as this is pretty important that it works.

@sebastienros sebastienros added this to the 1.4 milestone May 5, 2022
@sebastienros
Copy link
Member

Good thing we need to ship 1.4

Also, who wants to create a build step that verifies all the resources we have we shas on the CI?

@sebastienros
Copy link
Member

It could be a unit test, since we can fake the services, resolve all resource, and download them this way.

@agriffard
Copy link
Member

Related to #11580

@dsghi
Copy link

dsghi commented May 6, 2022

This is also causing #11388

@hishamco
Copy link
Member

hishamco commented May 6, 2022

It could be a unit test, since we can fake the services, resolve all resource, and download them this way.

I already did a PR long time for, that using source genrators, I think I need to continue work on it to avoid such SHA inconsistency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants