A field with the name: XX is already registered for GraphType: YY

[tropcicstefan]

Describe the bug

In #8669 @deanmarcussen did some builder changes so parts that aren't collapsed don't have double field registration. The thing is, there is no check when part is collapsed. So when other builder than DynamicContentTypeBuilder already builds some of the fields there is an error of double field registration.

Expected behavior

Use already added field by changing if (fieldType != null) to if (fieldType != null && !contentItemType.HasField(fieldType .Name)

[tropcicstefan]

New graphql brings new behaviour

Behaviour is same, still needs a fix, I misjudged while debugging

[lampersky]

@tropcicstefan could you have a look if this fix will solve your issue?

[Piedone]

@tropcicstefan could you please confirm if #13927 fixed this issue?

[tropcicstefan]

@Piedone it did fix my issue in the sense there is no exception thrown.
But it's weird that we now have double field in graphqltype for same property

made content type "test" with content part "ante" with textfield "MyProperty". Result is this image

[Piedone]

@lampersky could you comment on this, please?

[lampersky]

@Piedone I've just tried to repro, but with no luck

[Piedone]

Thank you! @tropcicstefan could you please check the same with a fresh install, just to rule out any previously existing config issues?

[Piedone]

If this was still a bug with main, then #16151 fixes it.