Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reCaptcha missing permission registration #12715

Closed
MikeKry opened this issue Oct 26, 2022 · 0 comments · Fixed by #12720
Closed

reCaptcha missing permission registration #12715

MikeKry opened this issue Oct 26, 2022 · 0 comments · Fixed by #12720
Assignees
@hishamco
Labels
bug 🐛
Milestone
1.5

Comments

@MikeKry
Copy link
Contributor

MikeKry commented Oct 26, 2022

ReCaptcha is missing permission registration in startup:
https://github.com/OrchardCMS/OrchardCore/blob/af2f9334b40243b1ba3c0f8f88e94ce5ed84cfd5/src/OrchardCore.Modules/OrchardCore.ReCaptcha/Startup.cs

but validates it in AdminMenu.cs with .Permission(Permissions.ManageReCaptchaSettings).

This causes that only administrator can manage reCaptcha and permission can't be added to other roles.
@hishamco hishamco self-assigned this Oct 26, 2022
@hishamco hishamco mentioned this issue Oct 26, 2022
Merged
@hishamco hishamco added this to the 1.x milestone Oct 26, 2022
@Skrypt Skrypt modified the milestones: 1.x, 1.5 Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hishamco hishamco

Labels
bug 🐛
Projects
None yet
Milestone
1.5
Development

Successfully merging a pull request may close this issue.

Add missing reCaptcha permission registration OrchardCMS/OrchardCore
3 participants
@Skrypt @hishamco @MikeKry