Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment step for removing and merging roles #13176

Open
MikeAlhayek opened this issue Jan 30, 2023 · 1 comment
Open

Add deployment step for removing and merging roles #13176

MikeAlhayek opened this issue Jan 30, 2023 · 1 comment
Milestone

Comments

@MikeAlhayek
Copy link
Member

Is your feature request related to a problem? Please describe.

Currently, we have RoleStep that would allow the user to create new roles. This step always removes all existing claims and loads only the claims you provide. This is a good step for introducing new roles.

However, in OC 1.6, the startup recipe will define which roles to user. Then the user want to update the existing role permissions, they have to list all the roles manually.

Describe the solution you'd like

It would be nice to add a property to the RoleStep to control the behavior of permission handling. For example, add a property called "PermissionBehavior", when the value is Replace "default", we would replace permission as we do today. However, if a user set it to Merge then we could just combine the permissions instead of removing existing.

Additionally, add a new step RemoveRoleStep that would allow us to remove existing roles.

@hishamco hishamco changed the title Add deployment step for removing and meging roles Add deployment step for removing and merging roles Jan 30, 2023
@jtkech
Copy link
Member

jtkech commented Jan 30, 2023

Yes, already part of one of my too long comment #13040 (comment) ;)

RoleStep: Hmm a little annoying, it specifies permissions (can be empty) that also rely on features activation, maybe the step should merge (not replace) permissions, at least when in a setup recipe, or maybe a new step for role creation only and if it already exists don't replace/clear its permissions.

@sebastienros sebastienros added this to the 1.x milestone Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants