Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let browsers auto-fill Scopes and Client Secret OpenId fields #13184

Closed
hyzx86 opened this issue Jan 31, 2023 · 3 comments · Fixed by #16160
Closed

Don't let browsers auto-fill Scopes and Client Secret OpenId fields #13184

hyzx86 opened this issue Jan 31, 2023 · 3 comments · Fixed by #16160

Comments

@hyzx86
Copy link
Contributor

hyzx86 commented Jan 31, 2023

As you can see in the screenshot, scopes and client secret are always filled in automatically,
And the content of the padding doesn't have any relevance
This might be a Chromium issue, but we should be able to turn it off by disabling the form's autofill property
I tried setting 'autocomplete='off'' on the input a few months ago and it didn't seem to work

image

@hyzx86
Copy link
Contributor Author

hyzx86 commented Jan 31, 2023

https://bugzilla.mozilla.org/show_bug.cgi?id=1119063

Can we use autocomplete ="new-password" to prevent autofill?
It doesn't make much sense, but it works

@Piedone Piedone changed the title form auto fill Don't let browsers auto-fill Scopes and Client Secret OpenId fields May 21, 2024
@Piedone Piedone added this to the backlog milestone May 21, 2024
@Piedone
Copy link
Member

Piedone commented May 21, 2024

For reference, the form is under /Admin/Settings/OrchardCore.OpenId.Client You need to tick "Use 'code' response type ".

@hyzx86
Copy link
Contributor Author

hyzx86 commented Jun 18, 2024

For reference, the form is under /Admin/Settings/OrchardCore.OpenId.Client You need to tick "Use 'code' response type ".

I had forgotten about it. I can't believe I suggested this 😅.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants