Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require element name for Input, Select, and TexArea to avoid exception #13326

Closed
MikeAlhayek opened this issue Feb 27, 2023 · 2 comments · Fixed by #13557
Closed

Require element name for Input, Select, and TexArea to avoid exception #13326

MikeAlhayek opened this issue Feb 27, 2023 · 2 comments · Fixed by #13557
Labels
Milestone

Comments

@MikeAlhayek
Copy link
Member

Describe the bug

If you add Input element to a form without specifying a name to the field, the content is saved. However, because it is missing a field name, it throws an exception when rendering it.

Expected behavior

an input widget should require at least a field name before saving.

@sebastienros sebastienros added this to the 1.x milestone Mar 16, 2023
@sebastienros
Copy link
Member

Or fix the exception when there is no name?

@MikeAlhayek
Copy link
Member Author

@sebastienros as discussed during the meeting, it does not make sense to have HTML element without a name. Id is still optional.

I submitted an PR that require a name for HTML element.

@sebastienros sebastienros modified the milestones: 1.x, 1.7 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants