Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove font-awesome 6.4 CDN from resources #13717

Closed
MikeAlhayek opened this issue May 19, 2023 · 4 comments · Fixed by #13720
Closed

Remove font-awesome 6.4 CDN from resources #13717

MikeAlhayek opened this issue May 19, 2023 · 4 comments · Fixed by #13720
Labels

Comments

@MikeAlhayek
Copy link
Member

Describe the bug

font-awesome 6.4 does not have a CDN but one is defined in the resources. Instead, maybe use the local resource using .SetUrl()

https://www.jsdelivr.com/package/npm/@fortawesome/fontawesome-free

When I used font 6.4 in production, I get issue with the integrity token
@agriffard

@hishamco
Copy link
Member

When I used font 6.4 in production, I get issue with the integrity token

Maybe the issue with the hash itself, it happens many times in the past

agriffard added a commit that referenced this issue May 20, 2023
@agriffard
Copy link
Member

Maybe the issue with the hash itself, it happens many times in the past

Sorry, my bad.
We still need a way to check SRIs.

@hishamco
Copy link
Member

We still need a way to check SRIs.

No worry, I will try to update my old PR that I started long time back

agriffard added a commit that referenced this issue May 20, 2023
@agriffard
Copy link
Member

FYI, I use this tool to get a SRI from a URL:
https://www.srihash.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants