Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to not require 2FA when the authentication is done by a 3rd party server #13955

Open
MikeAlhayek opened this issue Jul 6, 2023 · 5 comments
Milestone

Comments

@MikeAlhayek
Copy link
Member

Is your feature request related to a problem? Please describe.

If the app uses external service like Azure, Facebook, Google, or any other services, there should be an option in the 2FA settings to not require 2FA for these externally authorized users.

For example, services like Facebook, Azure or others may have 2FA process already in place.

@Piedone

@ns8482e
Copy link
Contributor

ns8482e commented Sep 13, 2023

Shouldn't disabling module enough?

@Piedone
Copy link
Member

Piedone commented Sep 13, 2023

No, you still need 2FA for local logins.

@ns8482e
Copy link
Contributor

ns8482e commented Sep 14, 2023

I see! So if you have mixed logins like local, azure, Google, Facebook etc and now the option will allow enable/disable 2FA per login provider?

@MikeAlhayek
Copy link
Member Author

@ns8482e yea because not all openId services support 2FA. I don't think there is anything indicate 2FA was used via openid response.

@kevinchalet is there a way to tell from the OpenId servers if 2FA was used? I know amr claim will have 2fa value whrn 2fa is used during login. But, amr claim does not always indicate correct value like when a user choose to remember their device.

@Piedone
Copy link
Member

Piedone commented Oct 11, 2023

Anybody interested in looking into this any time soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants