Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"The AzureAD Authentication is not correctly configured." warning when Azure AD is configured from the environment #14050

Open
Piedone opened this issue Jul 31, 2023 · 5 comments

Comments

@Piedone
Copy link
Member

Piedone commented Jul 31, 2023

Describe the bug

You get a "The AzureAD Authentication is not correctly configured." warning logged, coming from here, when Azure AD settings are configured from the environment, not site settings, via ConfigureAzureADSettings().

To Reproduce

Steps to reproduce the behavior:

  1. Configure Azure AD settings with ConfigureAzureADSettings().
  2. Launch the app.
  3. Observe the warning being logged immediately.

Expected behavior

No warning is logged when the configuration comes from the environment. However, a warning should be logged if no available configuration is correct.

@ns8482e
Copy link
Contributor

ns8482e commented Feb 14, 2024

Yes! warning message is misleading, however the order is correct. Settings are loaded first from settings by Configure and then overridden from appsettings config via PostConfigure .

So warning should state what it finds i.e. The AzureAD Authentication is not configured in site settings.

@Piedone
Copy link
Member Author

Piedone commented Feb 14, 2024

If the feature is configured correctly, regardless of where the config is coming from, then there should be no warning at all.

@hishamco
Copy link
Member

Is this fixed in the related PR, or shall I submit a PR?

@Piedone
Copy link
Member Author

Piedone commented Mar 18, 2024

It's isn't, and we won't do #15310.

Copy link
Contributor

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

@MikeAlhayek MikeAlhayek added the P2 label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants